GH-48658: [R] Add test for slice_sample with prop = 1 edge case#48659
Merged
jonkeane merged 1 commit intoapache:mainfrom Dec 27, 2025
Merged
GH-48658: [R] Add test for slice_sample with prop = 1 edge case#48659jonkeane merged 1 commit intoapache:mainfrom
jonkeane merged 1 commit intoapache:mainfrom
Conversation
|
|
github-actions
Bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 9e1e899. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The TODO comment in
test-dplyr-slice.Rasked whether the edge case whereprop = 1should be explicitly handled. The current implementation already correctly handles this case: whenprop = 1, theif (prop < 1)condition is false, so no filtering occurs and all data is returned.
arrow/r/R/dplyr-slice.R
Line 116 in 80e3986
The TODO was introduced in commit 80e3986 when implementing
slice_sample():arrow/r/tests/testthat/test-dplyr-slice.R
Line 192 in 80e3986
This commit added both the
if (prop < 1)behavior and the TODO comment, questioning whether the implicit behavior (doing nothing when prop = 1) was correct.What changes are included in this PR?
This PR adds a test for edge case of prop=1, and removed the todo comment.
Are these changes tested?
Yes, added unittest.
Are there any user-facing changes?
No, test-only.